Schedule polling for new meetings #12
Open
+3,350
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdungan
changed the title
groovecoder
requested changes
Mar 21, 2025
There was a problem hiding this comment.
change (blocking): don't check the *.jsonl file into the repo or we'll have to git commit them into the repo to update them. They should be put into the storage destination like S3 or something.
| SUMMARY_FILE = Path("data/summaries.jsonl") | ||
|
|
||
|
|
||
| async def load_meetings() -> List[Meeting]: |
There was a problem hiding this comment.
question (blocking): why is this async?
| ) | ||
|
|
||
| # Generate the AI summary | ||
| ai_summary = await summarize_with_llama(summary) |
There was a problem hiding this comment.
suggestion (non-blocking): If we're using aiohttp to do these concurrently, shouldn't we remove the await from this call? So the process can do all the summaries concurrently? Or am I forgetting how async http and concurrency works?
There was a problem hiding this comment.
Yes, a gather() does make sense here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up meeting data, add action to save meetings
Experimenting with github action to get new meetings and write summaries